-
Notifications
You must be signed in to change notification settings - Fork 131
Dependebility: Bumb protobuf version #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Contrary to osi-validation, which used a fixed version of protobuf (for unknown reasons, not recommended anyway), we do not specify a version of protobuf, or only specify a minimum version due to required features. Furthermore OSI is not intended to be used with untrusted sources for many other reasons anyway; for that reason I do not think we should change anything here, except maybe dropping the version in the README entirely. We are not in a position to force the use of a version of protobuf for unrelated, and often unnecessary reasons. For osi-validation I have changed the requirement to be a minimum version, and moved to 3.15.0 since one could argue that the validator should be more robust. |
So, two options:
|
I'd only go for option 1; for osi-validation there was already a version tie, so the proper course was to update, given that osi-validation is a validator. For OSI itself I would not talk about versions beyond what we currently have: There is little attack surface in most settings, and there are prescribed versions due to the overall build processes (e.g. need for same version across subsystems), so that all users already have to deal with that themselves. We'll see how the CCB feels about this, but that would be my opinion. |
Then we have the discussion and facts for a decision in the CCB. I have labeled the PR accordingly |
Output CCB 16.02.22:
|
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
cd459ce
to
fddf460
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve
@pmai there is a security issue with protobuffer that created an automatic version bumb PR in osi-validation. I am wondering three things here: